Add tracking feedback in FollowPath output port#5854
Merged
SteveMacenski merged 3 commits intoros-navigation:mainfrom Jan 13, 2026
Merged
Add tracking feedback in FollowPath output port#5854SteveMacenski merged 3 commits intoros-navigation:mainfrom
SteveMacenski merged 3 commits intoros-navigation:mainfrom
Conversation
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
mini-1235
commented
Jan 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
SteveMacenski
approved these changes
Jan 13, 2026
Member
|
Next steps here perhaps to use this information? 🥳 |
Contributor
Collaborator
Author
Yeah, I think #5602 is probably the only place that would benefit from this PR (aside from custom nodes for users who want to leverage this information) I have just open a PR #5864, which is somewhat related to #5037, but it doesn't use this information so that the bt navigator still works even without the controller server Another follow up I am planning to do in the near future for #5446 is to add a "dynamic prune distance", so users have fewer parameters to tune |
Lotusymt
pushed a commit
to Lotusymt/navigation2
that referenced
this pull request
Jan 16, 2026
* Add output port in FollowPath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Remove storing feedback Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Lotusymt
pushed a commit
to Lotusymt/navigation2
that referenced
this pull request
Jan 16, 2026
* Add output port in FollowPath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Remove storing feedback Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: lotusymt <mengtiy5@uci.edu>
Pana1v
pushed a commit
to Arnav-panjla/navigation2
that referenced
this pull request
Feb 21, 2026
* Add output port in FollowPath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Remove storing feedback Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.